Conversation
crazywhalecc
approved these changes
Jun 21, 2025
crazywhalecc
left a comment
crazywhalecc
left a comment
Owner
There was a problem hiding this comment.
I can't quite remember what this was for (never forget to annotate a specific patch), I'll test it locally later when I have time. But this pr is nothing wrong.
Collaborator
Author
|
I haven't tested it so I don't want to merge it yet. What I found on the internet was all about it being incompatible with certain extensions like memcached on MacOS, not Linux. |
Collaborator
Author
|
all tests with all extensions pass both static and shared, so I think we can merge this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
why did we need this? asm goto's should be perfectly fine on linux
was this specifically for glibc 2.17?